Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38741 )
Change subject: soc/intel/cannonlake: Add tdc config for CML ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38741/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38741/9//COMMIT_MSG@13 PS9, Line 13: UG BUG
https://review.coreboot.org/c/coreboot/+/38741/9/src/soc/intel/cannonlake/in... File src/soc/intel/cannonlake/include/soc/vr_config.h:
https://review.coreboot.org/c/coreboot/+/38741/9/src/soc/intel/cannonlake/in... PS9, Line 67: #define VR_CFG_TDC_AMP(i) ((i) * 8) should this have a cast as well?