Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36529 )
Change subject: arch/x86: Use TSC_MONOTONIC_TIMER for timestamps
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36529/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/36529/4//COMMIT_MSG@11
PS4, Line 11: timestamp_freq_tick_mhz() in lib/timestamp.c.
I think you should also indicate that this means TSC is not used for timestamps anymore by default a […]
Let me know if it was just bad idea to collect timestamps from monotonic timer via timer_monotonic_get(). Or if COLLECT_TIMESTAMPS for ChromeOS would forbid the granularity change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36529
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0adfbdeb456fbd6769fbd7f39421f797369876a8
Gerrit-Change-Number: 36529
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 02 Nov 2019 06:34:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment