Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37550 )
Change subject: mb/intel/kblrvp: Remove hex values from VR settings
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37550/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37550/3//COMMIT_MSG@13
PS3, Line 13: values in the tables. The values in the tables haven't changed.
When I first read this line, I understood "tables" referred to the table in the comment. I would suggest:
Also, correct some numbers in the comment tables that did not match the register values.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37550
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77af544d7d88143e19abedb12a13627779c705c6
Gerrit-Change-Number: 37550
Gerrit-PatchSet: 3
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Dec 2019 13:52:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment