EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37685 )
Change subject: soc/intel/cannonlake: Move GPIO PM configuration to soc level
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37685/6/src/soc/intel/cannonlake/ac...
File src/soc/intel/cannonlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/37685/6/src/soc/intel/cannonlake/ac...
PS6, Line 166: GCPM
Agreed, if we're moving the S0ix PM bits settings into the device tree, then may as well lump these […]
I would like to change it. RGPM (restore GPIO PM) and EGPM (enable GPIO PM).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I120f8369b8d3cf7ac821332bdfa124f6ed0570e9
Gerrit-Change-Number: 37685
Gerrit-PatchSet: 7
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 18 Dec 2019 04:12:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment