Hello Werner Zeh, Patrick Rudolph, Huang Jin, Julius Werner, Frans Hendriks, Patrick Rudolph, wvervoorn, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#11).
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
src: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Also, <soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/gpio.h M src/mainboard/amd/gardenia/gpio.c M src/mainboard/asrock/h110m/bootblock.c M src/mainboard/cavium/cn8100_sff_evb/mainboard.c M src/mainboard/esd/atom15/gpio.c M src/mainboard/esd/atom15/romstage.c M src/mainboard/facebook/fbg1701/gpio.c M src/mainboard/google/auron/chromeos.c M src/mainboard/google/auron/smihandler.c M src/mainboard/google/auron/variants/auron_paine/gpio.c M src/mainboard/google/auron/variants/auron_paine/pei_data.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/gpio.c M src/mainboard/google/auron/variants/auron_yuna/pei_data.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/buddy/gpio.c M src/mainboard/google/auron/variants/buddy/pei_data.c M src/mainboard/google/auron/variants/gandof/gpio.c M src/mainboard/google/auron/variants/gandof/pei_data.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/gpio.c M src/mainboard/google/auron/variants/lulu/pei_data.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/gpio.c M src/mainboard/google/auron/variants/samus/pei_data.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/auron/variants/samus/variant.c M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/cyan/com_init.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/cyan/spd/spd.c M src/mainboard/google/cyan/variants/banon/gpio.c M src/mainboard/google/cyan/variants/celes/gpio.c M src/mainboard/google/cyan/variants/celes/spd_util.c M src/mainboard/google/cyan/variants/cyan/gpio.c M src/mainboard/google/cyan/variants/edgar/gpio.c M src/mainboard/google/cyan/variants/kefka/gpio.c M src/mainboard/google/cyan/variants/reks/gpio.c M src/mainboard/google/cyan/variants/relm/gpio.c M src/mainboard/google/cyan/variants/setzer/gpio.c M src/mainboard/google/cyan/variants/setzer/spd_util.c M src/mainboard/google/cyan/variants/terra/gpio.c M src/mainboard/google/cyan/variants/ultima/gpio.c M src/mainboard/google/cyan/variants/wizpig/gpio.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/daisy/memory.c M src/mainboard/google/daisy/romstage.c M src/mainboard/google/daisy/wakeup.c M src/mainboard/google/dragonegg/bootblock.c M src/mainboard/google/dragonegg/chromeos.c M src/mainboard/google/dragonegg/mainboard.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/eve/bootblock.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/fizz/bootblock.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/fizz/ramstage.c M src/mainboard/google/fizz/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/foster/boardid.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/bootblock_mainboard.c M src/mainboard/google/glados/chromeos.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/hatch/bootblock.c M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/jecht/smihandler.c M src/mainboard/google/jecht/variants/guado/gpio.c M src/mainboard/google/jecht/variants/guado/pei_data.c M src/mainboard/google/jecht/variants/jecht/gpio.c M src/mainboard/google/jecht/variants/jecht/pei_data.c M src/mainboard/google/jecht/variants/rikku/gpio.c M src/mainboard/google/jecht/variants/rikku/pei_data.c M src/mainboard/google/jecht/variants/tidus/gpio.c M src/mainboard/google/jecht/variants/tidus/pei_data.c M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/romstage.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c M src/mainboard/google/kukui/bootblock.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/bootblock.c M src/mainboard/google/octopus/chromeos.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/octopus/smihandler.c M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/peach_pit/mainboard.c M src/mainboard/google/peach_pit/memory.c M src/mainboard/google/peach_pit/romstage.c M src/mainboard/google/peach_pit/wakeup.c M src/mainboard/google/poppy/bootblock.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/romstage.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/rambi/romstage.c M src/mainboard/google/rambi/variants/banjo/gpio.c M src/mainboard/google/rambi/variants/candy/gpio.c M src/mainboard/google/rambi/variants/clapper/gpio.c M src/mainboard/google/rambi/variants/enguarde/gpio.c M src/mainboard/google/rambi/variants/glimmer/gpio.c M src/mainboard/google/rambi/variants/gnawty/gpio.c M src/mainboard/google/rambi/variants/heli/gpio.c M src/mainboard/google/rambi/variants/kip/gpio.c M src/mainboard/google/rambi/variants/ninja/gpio.c M src/mainboard/google/rambi/variants/orco/gpio.c M src/mainboard/google/rambi/variants/quawks/gpio.c M src/mainboard/google/rambi/variants/rambi/gpio.c M src/mainboard/google/rambi/variants/squawks/gpio.c M src/mainboard/google/rambi/variants/sumo/gpio.c M src/mainboard/google/rambi/variants/swanky/gpio.c M src/mainboard/google/rambi/variants/winky/gpio.c M src/mainboard/google/reef/bootblock.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/smihandler.c M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/coral/mainboard.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/sarien/bootblock.c M src/mainboard/google/sarien/chromeos.c M src/mainboard/google/sarien/ramstage.c M src/mainboard/google/sarien/variants/arcada/include/variant/ec.h M src/mainboard/google/sarien/variants/sarien/include/variant/ec.h M src/mainboard/google/smaug/boardid.c M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/storm/gsbi.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/bayleybay_fsp/gpio.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/cannonlake_rvp/bootblock.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/cannonlake_rvp/mainboard.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/coffeelake_rvp/bootblock.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/mainboard.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/coffeelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/bootblock.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/mainboard.c M src/mainboard/intel/glkrvp/smihandler.c M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/icelake_rvp/mainboard.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/kblrvp/bootblock.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/bootblock_mainboard.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/minnowmax/gpio.c M src/mainboard/intel/minnowmax/romstage.c M src/mainboard/intel/saddlebrook/bootblock.c M src/mainboard/intel/saddlebrook/romstage.c M src/mainboard/intel/strago/com_init.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/strago/mainboard.c M src/mainboard/intel/strago/smihandler.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/intel/wtm2/gpio.c M src/mainboard/intel/wtm2/pei_data.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/mainboard/opencellular/elgon/mainboard.c M src/mainboard/opencellular/rotundu/romstage.c M src/mainboard/opencellular/rotundu/variants/rotundu/gpio.c M src/mainboard/opencellular/rotundu/variants/supabrckv1/gpio.c M src/mainboard/purism/librem_bdw/gpio.c M src/mainboard/siemens/mc_apl1/variants/baseboard/include/baseboard/variants.h M src/mainboard/siemens/mc_bdx1/romstage.c M src/mainboard/siemens/mc_tcu3/gpio.c M src/mainboard/siemens/mc_tcu3/romstage.c M src/soc/amd/common/block/gpio_banks/gpio.c M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/gpio.c M src/soc/amd/picasso/include/soc/gpio.h M src/soc/amd/picasso/include/soc/i2c.h M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/gpio.c M src/soc/amd/stoneyridge/include/soc/gpio.h M src/soc/amd/stoneyridge/include/soc/i2c.h M src/soc/cavium/cn81xx/gpio.c M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/include/soc/gpio.h M src/soc/intel/apollolake/lpc.c M src/soc/intel/apollolake/smihandler.c M src/soc/intel/apollolake/uart.c M src/soc/intel/baytrail/gpio.c M src/soc/intel/baytrail/include/soc/gpio.h M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/romstage/raminit.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/baytrail/romstage/uart.c M src/soc/intel/braswell/bootblock/bootblock.c M src/soc/intel/braswell/gpio.c M src/soc/intel/braswell/gpio_support.c M src/soc/intel/braswell/lpc_init.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/gpio.c M src/soc/intel/broadwell/include/soc/gpio.h M src/soc/intel/broadwell/lpc.c M src/soc/intel/broadwell/pcie.c M src/soc/intel/broadwell/pmutil.c M src/soc/intel/broadwell/romstage/romstage.c M src/soc/intel/cannonlake/include/soc/gpio.h M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/include/intelblocks/gpio.h M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/denverton_ns/include/soc/gpio.h M src/soc/intel/fsp_baytrail/bootblock/bootblock.c M src/soc/intel/fsp_baytrail/gpio.c M src/soc/intel/fsp_baytrail/include/soc/gpio.h M src/soc/intel/fsp_baytrail/ramstage.c M src/soc/intel/fsp_baytrail/romstage/romstage.c M src/soc/intel/fsp_baytrail/romstage/uart.c M src/soc/intel/fsp_broadwell_de/gpio.c M src/soc/intel/icelake/include/soc/gpio.h M src/soc/intel/icelake/pmutil.c M src/soc/intel/skylake/include/soc/smm.h M src/soc/intel/skylake/pmutil.c M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/spi.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/qcs405/qup.c M src/soc/qualcomm/qcs405/uart.c M src/soc/qualcomm/sdm845/qspi.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c M src/soc/samsung/exynos5250/gpio.c M src/soc/samsung/exynos5250/pinmux.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/gpio.c M src/soc/samsung/exynos5420/pinmux.c M src/soc/samsung/exynos5420/usb.c 298 files changed, 257 insertions(+), 289 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/11