Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47659 )
Change subject: soc/intel/common/fast_spi: Add custom boot media device ......................................................................
Patch Set 18:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47659/16/src/soc/intel/common/block... File src/soc/intel/common/block/fast_spi/Kconfig:
https://review.coreboot.org/c/coreboot/+/47659/16/src/soc/intel/common/block... PS16, Line 20: (r
nit: space before (
Done
https://review.coreboot.org/c/coreboot/+/47659/16/src/soc/intel/common/block... PS16, Line 27: r
map *the* rest
Done
https://review.coreboot.org/c/coreboot/+/47659/16/src/soc/intel/common/block... PS16, Line 56: default n
I think it still needs the `bool` here?
As per https://doc.coreboot.org/getting_started/kconfig.html#notes: "Only the first type definition for each symbol is valid. Further matching definitions are fine, although unnecessary. Conflicting type definitions will be ignored, and a warning will be presented on the console where the configuration front end was run: warning: ignoring type redefinition of ‘SYMBOL’ from ‘hex’ to ‘integer’."