Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40933 )
Change subject: acpi: Update sata files to be more aligned with rest of acpi files
......................................................................
Patch Set 9: Code-Review+2
Patch Set 8:
Patch Set 5: Code-Review+1
do we want files named under 'acpi' directory with acpi_ prefix? Is it redundant? I get the header file argument, but does the c file naming need to be like that? Thinking out loud, fwiw.
Makes sense.. i can go the other way.
I would drop it on headers too, but that is a pain..
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40933
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f97e5c12535a331d7347c0ecad00b07b5f13f37
Gerrit-Change-Number: 40933
Gerrit-PatchSet: 9
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 02 May 2020 02:26:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment