[coreboot-gerrit] Change in coreboot[master]: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34166 )

Change subject: soc/intel/{cnl,icl}: Drop insane defaults for CAR implementation
......................................................................

Patch Set 1: Code-Review-2

(1 comment)

i really don't know what is the problem with "insane" defaults as all chrome platforms are using CAR NEM enhance by default and IOTG users are using FSP-T for CAR. i'm not sure if our IOTG folks are using any internal patch to make FSP_CAR working. Till that clarifies my -2 here, as i know this patch will merge fast.

https://review.coreboot.org/c/coreboot/+/34166/1/src/soc/intel/cannonlake/Kc... 
File src/soc/intel/cannonlake/Kconfig:

https://review.coreboot.org/c/coreboot/+/34166/1/src/soc/intel/cannonlake/Kc... 
PS1, Line 274: 
Do you recommend the user now to select what is CAR option now ?