Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38387 )
Change subject: soc/intel/{apl,cnl,icl,skl,tgl}: Update SA bit fields as per EDS ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38387/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/systemagent.h:
https://review.coreboot.org/c/coreboot/+/38387/2/src/soc/intel/common/block/... PS2, Line 56: is_64_bit
Is there any case in which this is false?
looks like right now all resources that we are passing are 64 bit width but their might be some fixed resource which possible to be 32 bit width as well hence i have created this additional field else it would be hardcoding a lot