[coreboot-gerrit] Change in coreboot[master]: mb/{facebook/portwell}: Define SDCARD_CD in dsdt.asl

[Wim Vervoorn (Code Review)]

Hello Frans Hendriks,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/37610

to review the following change.

Change subject: mb/{facebook/portwell}: Define SDCARD_CD in dsdt.asl
......................................................................

mb/{facebook/portwell}: Define SDCARD_CD in dsdt.asl

SDCARD_CD is defined in onboard.h but required in ASL only, move this
define to dsdt.asl.
Removed the onboard.h file from the ASL files that don use it.

BUG=N/A
TEST=build

Change-Id: I35b75e0ae2e2bc4ce143aaec6df6016774676095
Signed-off-by: Wim Vervoorn 
---
M src/mainboard/facebook/fbg1701/acpi/mainboard.asl
M src/mainboard/facebook/fbg1701/acpi/superio.asl
M src/mainboard/facebook/fbg1701/dsdt.asl
M src/mainboard/facebook/fbg1701/onboard.h
M src/mainboard/portwell/m107/acpi/superio.asl
M src/mainboard/portwell/m107/dsdt.asl
6 files changed, 4 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/37610/1

diff --git a/src/mainboard/facebook/fbg1701/acpi/mainboard.asl b/src/mainboard/facebook/fbg1701/acpi/mainboard.asl
index 9575748..af79bd7 100644
--- a/src/mainboard/facebook/fbg1701/acpi/mainboard.asl
+++ b/src/mainboard/facebook/fbg1701/acpi/mainboard.asl
@@ -16,8 +16,6 @@
  * GNU General Public License for more details.
  */

-#include "onboard.h"
-
 Scope (_SB)
 {
    Device (PWRB)
diff --git a/src/mainboard/facebook/fbg1701/acpi/superio.asl b/src/mainboard/facebook/fbg1701/acpi/superio.asl
index bdaa912..4fa6772 100644
--- a/src/mainboard/facebook/fbg1701/acpi/superio.asl
+++ b/src/mainboard/facebook/fbg1701/acpi/superio.asl
@@ -15,9 +15,6 @@
  * GNU General Public License for more details.
  */

-/* mainboard configuration */
-#include "onboard.h"
-
 Device (COM1) {
    Name (_HID, EISAID ("PNP0501"))
    Name (_UID, 1)
diff --git a/src/mainboard/facebook/fbg1701/dsdt.asl b/src/mainboard/facebook/fbg1701/dsdt.asl
index 4eea7b9..518e249 100644
--- a/src/mainboard/facebook/fbg1701/dsdt.asl
+++ b/src/mainboard/facebook/fbg1701/dsdt.asl
@@ -18,6 +18,8 @@

#include <arch/acpi.h>

+#define SDCARD_CD 81 /* Not used */
+
 DefinitionBlock(
    "dsdt.aml",
    "DSDT",
diff --git a/src/mainboard/facebook/fbg1701/onboard.h b/src/mainboard/facebook/fbg1701/onboard.h
index 6e094ab..715f76a 100644
--- a/src/mainboard/facebook/fbg1701/onboard.h
+++ b/src/mainboard/facebook/fbg1701/onboard.h
@@ -18,9 +18,6 @@
 #ifndef ONBOARD_H
 #define ONBOARD_H

-/* SD CARD gpio */
-#define SDCARD_CD 81 /* Not used */
-
 /* Define the items to be measured or verified */
 #define FSP (const char *)"fsp.bin"
 #define CMOS_LAYOUT (const char *)"cmos_layout.bin"
diff --git a/src/mainboard/portwell/m107/acpi/superio.asl b/src/mainboard/portwell/m107/acpi/superio.asl
index e411f72..309a26b 100644
--- a/src/mainboard/portwell/m107/acpi/superio.asl
+++ b/src/mainboard/portwell/m107/acpi/superio.asl
@@ -15,8 +15,6 @@
  * GNU General Public License for more details.
  */

-/* mainboard configuration */
-#include "onboard.h"

Device (COM1) {
    	Name (_HID, EISAID ("PNP0501"))
diff --git a/src/mainboard/portwell/m107/dsdt.asl b/src/mainboard/portwell/m107/dsdt.asl
index 4eea7b9..518e249 100644
--- a/src/mainboard/portwell/m107/dsdt.asl
+++ b/src/mainboard/portwell/m107/dsdt.asl
@@ -18,6 +18,8 @@

#include <arch/acpi.h>

+#define SDCARD_CD 81 /* Not used */
+
 DefinitionBlock(
    "dsdt.aml",
    "DSDT",