Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38926 )
Change subject: Documentation: Add GM45 ThinkPads common page ......................................................................
Patch Set 8: Code-Review+1
(9 comments)
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... File Documentation/mainboard/lenovo/montevina_series.md:
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 3: MB flash chip sizes are multiples of 1024, not 1000: s/MB/MiB/g
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 4: chip in your machine through flashrom: Note that this does not allow you to determine whether the chip is in a SOIC-8 or a SOIC-16 package.
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 18: make make*s*
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 26: Then extract FD modules to a separate files I would reword this a bit:
Then, split the IFD regions into separate filse with ifdtool.
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 26: Your You
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 78: Creating new Creating *a* new
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 80: generate modified generate *a* modified
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 129: touch other touch *any* other
https://review.coreboot.org/c/coreboot/+/38926/8/Documentation/mainboard/len... PS8, Line 129: with flash with *the* flash
(and it's actually "firmware descriptor", but it's not really a big deal)