[coreboot-gerrit] Change in ...coreboot[master]: arch/x86/cpu: Add functions to determine CPU vendor

[Julien Viard de Galbert (Code Review)]

Julien Viard de Galbert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32130 )

Change subject: arch/x86/cpu: Add functions to determine CPU vendor
......................................................................

Patch Set 1: Code-Review+1

Hello Patrick,

If I understand correctly you are trying to skip the call to `identify_cpu` by looking at the Kconfig options for some AMD and some Intel cpu/soc but not all of them (so you still need the call as a fallback).

I don't really see the point of having the two functions, you could call `identify_cpu`
and test cpu.vendor directly. I my opinion, the code will be easy to read in both cases.

But I might be missing something.

Anyway the code looks correct, so +1.

Best Regards,

Julien VdG