Venkata Krishna Nimmagadda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40261 )
Change subject: mb/google/volteer: Work around TPM issue by enabling GPIO PM in S0ix
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40261/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40261/6//COMMIT_MSG@7
PS6, Line 7: mb/google/volteer: Add workaround for GPIO PM on S0ix entry/exit
Sorry for the confusion, but *for* needs to be changed, if you use the verb in imperative mood. […]
Fixed it. Thank you for your time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40261
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If522c82c0069a4bf5738beb73a2b4f11ed6f51d3
Gerrit-Change-Number: 40261
Gerrit-PatchSet: 9
Gerrit-Owner: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Raj Astekar
raj.astekar@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 17 Apr 2020 20:40:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Venkata Krishna Nimmagadda
Venkata.krishna.nimmagadda@intel.com
Gerrit-MessageType: comment