Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47192 )
Change subject: mb/purism/librem_mini: Adjust GPIO reset values
......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
When the hex values are the values read from the registers, the reset values are already correct.
These have been adjusted as per schematics, since vendor firmware values don't make much sense. But I agree that the raw values are now useless.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47192
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d6a72d2e3597234c8fde86e028b033b3c8d36ae
Gerrit-Change-Number: 47192
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Nov 2020 00:04:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment