Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35293 )
Change subject: Add ThinkPad R60 iGPU support. ......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35293/15/src/mainboard/lenovo/r60/g... File src/mainboard/lenovo/r60/gpio.c:
https://review.coreboot.org/c/coreboot/+/35293/15/src/mainboard/lenovo/r60/g... PS15, Line 17: #define BOARD_GPIO_H Remove this #ifdef block. It's not necessary
https://review.coreboot.org/c/coreboot/+/35293/15/src/mainboard/lenovo/r60/g... PS15, Line 21: const struct pch_gpio_set1 pch_gpio_set1_mode = { Could you please use static const struct everywhere in this file (as autoport does). This is more consistent with the rest of codebase.
https://review.coreboot.org/c/coreboot/+/35293/15/src/mainboard/lenovo/r60/g... PS15, Line 125: #endif Remove this #ifdef block. It's not necessary.
See comment above.