Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34367 )
Change subject: util: Add new util to make a payload for QEMU/AArch64 ......................................................................
Patch Set 2:
Patch Set 2:
(3 comments)
I'm thinking to write shell/python script to generate payload.its because I want to use an environmental variable (e.g. specifying the place of Linux kernel) but .its file seems not to support variables.
You could just put a marker string like ###KERNEL_FILE### in it, copy it into the build directory and then use 'sed' to replace it with what you want? See the rule for fmap.fmd in coreboot's toplevel Makefile.inc, it does something similar. We try to avoid Python dependencies where possible.
I don't see the benefit. It's not related to qemu_aarch64 at all.
- That's already in the documentation
- That's already integrated into the make system if you select LinuxBoot payload.
Not everyone is using LinuxBoot? I think having something that helps people in building a simple FIT image from scratch may be useful... whether it should be tied to QEMU or not is debatable (for non-QEMU boards you'd have to pass a .dts or .dtb in as well, then). I guess we could consider integrating this into payloads/external/linux instead of having a separate thing under util/, maybe that would be better?
For payloads/external/LinuxBoot, I agree that it would be nice to integrate support for auto-generating the DTB when using QEMU there.
The LinuxBoot payload (if it wouldn't be broken right now on arm64), allows you to include any combination of kernel, DTS and initramfs. It's totally unrelated to u-root. The Linux payload is deprecated and LinuxBoot should be used instead.
Duplicating code from LinuxBoot doesn't seem like a good idea.