Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45047 )
Change subject: sb/intel/lynxpoint: Do not determine PCH type at runtime
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45047/3/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/early_pch.c:
https://review.coreboot.org/c/coreboot/+/45047/3/src/southbridge/intel/lynxp...
PS3, Line 40: get_pch_platform_type() == PCH_TYPE_ULT
The only sane thing we could do is die()
Sure.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45047
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba904acf64096478d1b76ffd05a076f0203502f8
Gerrit-Change-Number: 45047
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 10 Sep 2020 06:55:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment