Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39868 )
Change subject: mb/google/deltaur: Return SKU ID info ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39868/8/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/sku.c:
https://review.coreboot.org/c/coreboot/+/39868/8/src/mainboard/google/deltau... PS8, Line 18: const static sku_info skus[] = { : /* Deltan 360 - invalid configuration */ : { .id = -1, .name = "sku_invalid" }, : /* Deltan */ : { .id = 1, .name = "sku1" }, : /* Deltan 360 signed - invalid configuration */ : { .id = -1, .name = "sku_invalid" }, : /* Deltan signed */ : { .id = 2, .name = "sku2" }, : }; : : static const uint32_t get_sku_index(void) : { : return ((!has_360_sensor_board()) | (wilco_ec_signed_fw() << 1)); : } Since Deltan does not have the 360 sensor board, how about rewriting it without that? Something like:
skus[] = { { .id = 1, .name = "sku1" }, { .id = 2, .name = "sku2" }, };
get_sku_index(void) { return wilco_ec_signed_fw(); }
?
https://review.coreboot.org/c/coreboot/+/39868/8/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/include/variant/variants.h:
https://review.coreboot.org/c/coreboot/+/39868/8/src/mainboard/google/deltau... PS8, Line 10: : I created a partner bug for this. Can you add b/153027724 in the comment?
https://review.coreboot.org/c/coreboot/+/39868/8/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/sku.c:
https://review.coreboot.org/c/coreboot/+/39868/8/src/mainboard/google/deltau... PS8, Line 31: ! !! would be a little more correct here.