Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46855 )
Change subject: mrc_cache: Move code for triggering memory training into mrc_cache
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46855/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46855/6//COMMIT_MSG@11
PS6, Line 11: Moving the code that makes this decision into the mrc_cache.
This sentence comes a little unmotivated for me. Maybe (if correct): […]
Done
https://review.coreboot.org/c/coreboot/+/46855/4/src/drivers/mrc_cache/mrc_c...
File src/drivers/mrc_cache/mrc_cache.c:
https://review.coreboot.org/c/coreboot/+/46855/4/src/drivers/mrc_cache/mrc_c...
PS4, Line 659: CONFIG(HAS_RECOVERY_MRC_CACHE
In (!A || (A && B)) the second A is redundant, you can just write (!A || B) […]
All this logic has been moved into invalidate_normal_cache()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46855
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3875a7b4a4ba3c1aa8a3c1507b3993036a7155fc
Gerrit-Change-Number: 46855
Gerrit-PatchSet: 10
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 13 Nov 2020 07:14:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment