[coreboot-gerrit] [S] Change in coreboot[master]: drivers/net/phy/m88e1512: Switch the page back to 0 only once

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73017 )

Change subject: drivers/net/phy/m88e1512: Switch the page back to 0 only once
......................................................................

drivers/net/phy/m88e1512: Switch the page back to 0 only once

When the configuration of Marvell PHY 88E1512 is finished, then switch
the page back to 0 only once at the end of the Init function.

Change-Id: I9e516870a7c5928724df2bd3ac9c5c8f3249af2e
Signed-off-by: Mario Scheithauer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73017
Reviewed-by: Werner Zeh 
Tested-by: build bot (Jenkins) 
Reviewed-by: Arthur Heymans 
---
M src/drivers/net/phy/m88e1512/m88e1512.c
1 file changed, 20 insertions(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Werner Zeh: Looks good to me, approved
  Arthur Heymans: Looks good to me, approved

diff --git a/src/drivers/net/phy/m88e1512/m88e1512.c b/src/drivers/net/phy/m88e1512/m88e1512.c
index f32991f..5ce9b40 100644
--- a/src/drivers/net/phy/m88e1512/m88e1512.c
+++ b/src/drivers/net/phy/m88e1512/m88e1512.c
@@ -52,9 +52,6 @@
    	clrsetbits16(&reg, LED_FUNC_CTRL_MASK, config->led_0_ctrl |
    			(config->led_1_ctrl << 4) | (config->led_2_ctrl << 8));
    	mdio_write(dev, LED_FUNC_CTRL_REG, reg);
-
-		/* Switch back to page 0. */
-		switch_page(dev, 0);
    }

/* INTn can be routed to LED[2] pin. */
@@ -68,10 +65,10 @@
    	reg = mdio_read(dev, LED_TIMER_CTRL_REG);
    	setbits16(&reg, LED_IRQ_ENABLE);
    	mdio_write(dev, LED_TIMER_CTRL_REG, reg);
-
-		/* Switch back to page 0. */
-		switch_page(dev, 0);
    }
+
+	/* Switch back to page 0. */
+	switch_page(dev, 0);
 }

struct device_operations m88e1512_ops = {