EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40560 )
Change subject: soc/intel/tigerlake: Check SPD is not NULL before print ......................................................................
soc/intel/tigerlake: Check SPD is not NULL before print
Check SPD is not NULL before print. Thsi can avoid system hang up.
BUG=b:154445630 TEST=Check NULL SPD is not print.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Iccd9fce99eda7ae2b8fb1b4f3c2e635c2a428f04 --- M src/soc/intel/tigerlake/meminit.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/40560/1
diff --git a/src/soc/intel/tigerlake/meminit.c b/src/soc/intel/tigerlake/meminit.c index 8664547..1210bcd 100644 --- a/src/soc/intel/tigerlake/meminit.c +++ b/src/soc/intel/tigerlake/meminit.c @@ -308,7 +308,7 @@ get_spd_smbus(blk);
for (i = 0; i < ARRAY_SIZE(blk->addr_map); i++) { - if (blk->addr_map[i]) + if (blk->addr_map[i] && blk->spd_array[i] != NULL) print_spd_info((unsigned char *)blk->spd_array[i]); } }