Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42470 )
Change subject: drivers/intel/mipi_camera: Add support to handle CIO2 device
......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42470/12/src/drivers/intel/mipi_cam...
File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/42470/12/src/drivers/intel/mipi_cam...
PS12, Line 87: for (i = 0; i < config->cio2_num_ports; ++i) {
: free(ep_table_name[i]);
: free(port_table_name[i]);
: free(port_name[i]);
: }
Hrm, given the style's suggestion to use malloc() as a last resort another option is to use somethin […]
And that alternative uses an extra 384 bytes of stack space... the memory has to come from somewhere either way. I don't think either option is great, it's just an artifact of the current acpi_dp_* API, which already is a heavy malloc() user.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42470
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I521740524bc1c4da3d8593f011a033542e4a872c
Gerrit-Change-Number: 42470
Gerrit-PatchSet: 14
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt Delco
delco@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 30 Jun 2020 22:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt Delco
delco@google.com
Comment-In-Reply-To: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment