Alex Thiessen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32901 )
Change subject: string.h: Move common string functions into .c file
......................................................................
Patch Set 3:
Patch Set 3:
The generated line below has an invalid email address (domain part).
Reviewed-by: Alex Thiessen <alex.thiessen.de+coreboot@gmail.com+coreboot@gmail.com>
That's some stupid email address parsing bug on Gerrit side. Don't know if it's coreboot-specific or a genuine Gerrit issue. A quick search in https://bugs.chromium.org/p/gerrit/issues did not return any existing ticket that covers this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32901
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88166ba9876e94dfa3cfc06969c78a9e1bc6fc36
Gerrit-Change-Number: 32901
Gerrit-PatchSet: 3
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Alex Thiessen
alex.thiessen.de+coreboot@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 02 Jul 2019 00:01:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment