[coreboot-gerrit] Change in ...coreboot[master]: nb/intel/i945: Set CxDRT1 tRPALL bit if populated with 8-bank

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28648 )

Change subject: nb/intel/i945: Set CxDRT1 tRPALL bit if populated with 8-bank
......................................................................

Patch Set 7:

(1 comment)
> Also, according to "Intel® 945G/945GZ/945GC/945P/945PL Express
> Chipset Family", this bit is reserved on desktop variants. I don't
> think it should be set.

"Intel® 945G/945GZ/945GC/945P/945PL Express Chipset Family" is shitty.. :)

https://review.coreboot.org/#/c/28648/7/src/northbridge/intel/i945/raminit.c 
File src/northbridge/intel/i945/raminit.c:

https://review.coreboot.org/#/c/28648/7/src/northbridge/intel/i945/raminit.c... 
PS7, Line 1495: 		if (sysinfo->banks[i] != 8)
              : 			continue;
              : 		temp_drt |= (1 << 16);
> Since we only want to set this bit once, why don't we do the following: […]

Done