Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46599 )
Change subject: soc/intel/xeon_sp/skx/acpi.c: Update with cpx changes ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46599/1/src/soc/intel/xeon_sp/skx/a... File src/soc/intel/xeon_sp/skx/acpi.c:
https://review.coreboot.org/c/coreboot/+/46599/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 93: for (int socket = 0; socket < hob->PlatformData.numofIIO; ++socket) { Where did the for-socket loop go?
https://review.coreboot.org/c/coreboot/+/46599/1/src/soc/intel/xeon_sp/skx/a... PS1, Line 242: return NULL; Huh? Is this intentional?
It could also be that the code for SKX-SP was copy-pasta'd from Skylake and is wrong, in which case I'd prefer to remove this on a separate commit (so that the commit message can explain why it is being removed).