Bhanu Prakash Maiya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44423 )
Change subject: mb/google/zork: Use FW_CONFIG to enable/disable eMMC on Ezkinil
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44423/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/ezkinil/variant.c:
https://review.coreboot.org/c/coreboot/+/44423/1/src/mainboard/google/zork/v...
PS1, Line 16: * or FW boots on unprovisioned board in factory.
Comment may fit on a single 96 col line.
Ack
https://review.coreboot.org/c/coreboot/+/44423/1/src/mainboard/google/zork/v...
PS1, Line 18: if (!(variant_has_emmc() ||
This can be on one line.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44423
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62318cf71ec70790f2d9e787febd1e0b787741fb
Gerrit-Change-Number: 44423
Gerrit-PatchSet: 2
Gerrit-Owner: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Assignee: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Aug 2020 20:42:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment