Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34195 )
Change subject: driver/spi: Drop HAVE_SMI_HANDLER dependency
......................................................................
Patch Set 1:
I think all this really does is removes SPI_FLASH_SMM from .config. Remeber, with HAVE_SMI_HANDLER we do not even build the smm-class this SPI feature would be built into.
Well, but then you have features selected that you don't get.
I'd prefer to have that visible in config / errors on conflicts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34195
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I620d3ce5aa9632d862d6480922144f002cf6423b
Gerrit-Change-Number: 34195
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 11 Jul 2019 21:18:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment