Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34180 )
Change subject: mb/google/hatch: Enable/disable GPIO clock gating
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34180/5/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/34180/5/src/mainboard/google/hatch/...
PS5, Line 24: For (Local0 = 0, Local0 < 5, Local0++)
: {
: _SB.PCI0.CGPM (Local0, MISCCFG_ENABLE_GPIO_PM_CONFIG)
: }
Put this in a method of its own which can be called by MPTS, MWAK and MS0X?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20ff2aac035eaa5912af6c946d837567a4918bbf
Gerrit-Change-Number: 34180
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Evan Green
evgreen@chromium.org
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-Comment-Date: Tue, 09 Jul 2019 22:35:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment