Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/27609 )
Change subject: soc/intel/skylake: permit Kconfig to set subsystem ID ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
With this change there are two different methods to have FSP configure subsystemID (Kconfig and devicetree) and another one from devicetree with .set_subsystem pci ops? Why?
https://review.coreboot.org/#/c/27609/1/src/soc/intel/skylake/chip_fsp20.c File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/#/c/27609/1/src/soc/intel/skylake/chip_fsp20.c@3... PS1, Line 380: ifdef
The IS_ENABLED only works with boolean parameters, and this setting is the actual value of the vendo […]
sorry overlooked that...