Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37794 )
Change subject: soc/intel/cannonlake: Pass GPIO PM configuration devicetree.cb to ASL ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37794/2/src/soc/intel/cannonlake/gp... File src/soc/intel/cannonlake/gpio_common.c:
https://review.coreboot.org/c/coreboot/+/37794/2/src/soc/intel/cannonlake/gp... PS2, Line 28: memset(misccfg_pm_values, MISCCFG_ENABLE_GPIO_PM_CONFIG,
Do we still enable by default? And if we get rid of FSP-S, we can skip overwrite here just write the […]
did we discussed to not override ? i don't recall. I guess Furquan said last time to not dependent on FSP-S and if coreboot user doesn't enable gpio_override_pm then we should enable this feature by default and it might have power saving and we don't want to miss those on non-chrome platform with coreboot may be ?