Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35189 )
Change subject: util/inteltool: add many missing registers for skl/kbl ......................................................................
Patch Set 6:
(3 comments)
only looked at the ahci change for now; will look at the rest later
https://review.coreboot.org/c/coreboot/+/35189/6//COMMIT_MSG Commit Message:
PS6: would be good if you added the corresponding document id (332691-003EN)
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/ahci.c File util/inteltool/ahci.c:
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/ahci.c@124 PS6, Line 124: case 8: : printf("0x%04x: 0x%08x (%s)\n" : " 0x%08x\n", : ahci_cfg_registers[i].addr, : pci_read_long(ahci, ahci_cfg_registers[i].addr), : ahci_cfg_registers[i].name, : pci_read_long(ahci, ahci_cfg_registers[i].addr+4)); : break; not needed
https://review.coreboot.org/c/coreboot/+/35189/6/util/inteltool/ahci.c@164 PS6, Line 164: 0xa0 add a define for this register?