Attention is currently required from: Nico Huber, Jeremy Soller.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 )
Change subject: pciexp: Add support for allocating PCI express hotplug resources
......................................................................
Patch Set 6:
(1 comment)
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/35946/comment/56aac701_33950bf8
PS6, Line 563:
: /* Add dummy slot to preserve resources, must happen after bus scan */
: struct device *dummy;
: struct device_path dummy_path = { .type = DEVICE_PATH_NONE };
: dummy = alloc_dev(dev->link_list, &dummy_path);
: dummy->ops = &pciexp_hotplug_dummy_ops;
:
This causes an error: `[ERROR] NONE missing set_resources`
I have no idea if `set_resources` is really required for the dummy device, or if it's enough to introduce `DEVICE_PATH_DUMMY` which doesn't print an error during resource allocation.
@Nico, ideas?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35946
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc
Gerrit-Change-Number: 35946
Gerrit-PatchSet: 6
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Bill XIE
persmule@hardenedlinux.org
Gerrit-CC: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-CC: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-CC: Duncan Laurie
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Mimoja
coreboot@mimoja.de
Gerrit-CC: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jeremy Soller
jeremy@system76.com
Gerrit-Comment-Date: Thu, 24 Mar 2022 20:51:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment