Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42140 )
Change subject: ACPI: Define acpi_get_preferred_pm_profile()
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42140/1/src/arch/x86/acpi_pm.c
File src/arch/x86/acpi_pm.c:
https://review.coreboot.org/c/coreboot/+/42140/1/src/arch/x86/acpi_pm.c@8
PS1, Line 8: int enclosure = smbios_mainboard_enclosure_type();
I thought of adding second switch that stringifies the enum name on console.
ah, okay. in any case, I'd make it const
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42140
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e7f22ccccc6c0df8e7e9f354c50893a53a41714
Gerrit-Change-Number: 42140
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 10 Jun 2020 22:03:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment