Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45635 )
Change subject: vendorcode/google: add CHROMEOS_DRAM_PART_NUMBER_IN_CBI Kconfig option ......................................................................
Patch Set 22:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45635/22/src/vendorcode/google/chro... File src/vendorcode/google/chromeos/dram_part_num_override.c:
https://review.coreboot.org/c/coreboot/+/45635/22/src/vendorcode/google/chro... PS22, Line 19: printk(BIOS_ERR, : "ERROR: Couldn't obtain DRAM part number from CBI\n"); : part_num_state = PART_NUM_NOT_IN_CBI; These need to be put inside braces. Also, since `if` block is using braces, you will need it for the `else` block as well (Coreboot coding guidelines).
https://review.coreboot.org/c/coreboot/+/45635/22/src/vendorcode/google/chro... PS22, Line 23: ; Extra semicolon.