Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47980 )
Change subject: lp4x: Add new memory parts and generate SPDs ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47980/1/util/spd_tools/lp4x/global_... File util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/47980/1/util/spd_tools/lp4x/global_... PS1, Line 221: {
looks like you have a mix of tabs and spaces for indentation.
Thanks, will fix it on next patch upload.
https://review.coreboot.org/c/coreboot/+/47980/1/util/spd_tools/lp4x/global_... PS1, Line 226: 1
Doesn't this part have 2 channels per die?
From spec: • Array configuration – 512 Meg × 64 (4 channels × 16 I/O) 512M64 • Device configuration – 512M16 × 4 die in package
I thought that breaks down to 1 channel per die.
There are only two ZQ pins, so we set diesPerPackage to 2 instead of 4. Does that mean that we need to double the channelsPerDie since we half the die count so that we still end up with a total channel count of 4 for the package?