Attention is currently required from: Matt DeVillier, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38922 )
Change subject: libgfxinit: Allow to configure screen rotation
......................................................................
Patch Set 7:
(2 comments)
File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/38922/comment/ea8cb72a_52da8224
PS7, Line 500: how the physical screen is mounted in
: 90 degree steps
are the steps clockwise or counter-clockwise?
Positive degrees are counter-clockwise. Is it necessary to
teach people that in Kconfig help texts? ;)
https://review.coreboot.org/c/coreboot/+/38922/comment/f76b1963_15c3c161
PS7, Line 507: Straight
nit: How about "No rotation"?
How about "Upright"? I strugle a bit to find the most common, least
stigmatized vocable, but I would prefer to have an adjective here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38922
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac75cefbd34f28c55ec20ee152fe67351cc48653
Gerrit-Change-Number: 38922
Gerrit-PatchSet: 7
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 05 Sep 2021 14:05:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment