Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39731 )
Change subject: [WIP] drivers/intel/gma: Provide default definition for integrated panel ......................................................................
Patch Set 2:
(1 comment)
if the goal with this patch is to simplify drivers_intel_gma_displays_ssdt_generate(), why not just drop ndid/did[] from i915_gpu_controller_info struct and just have the ssdt generator produce a single entry for LCD0, since all the data for it is known and static? Dragging i915_gpu_controller_info forward to newer platforms when we have a single fixed did entry and the rest of the fields aren't relevant/used for the platform seems unnecessary. Platforms can simply call drivers_intel_gma_displays_ssdt_generate(void) if a given board has an internal panel driven by the IGD.
https://review.coreboot.org/c/coreboot/+/39731/2/src/mainboard/samsung/stump... File src/mainboard/samsung/stumpy/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39731/2/src/mainboard/samsung/stump... PS2, Line 2: # IGD Displays : register "gfx" = "GMA_DEFAULT_PANEL" stumpy is a Chromebox, it doesn't have an integrated panel