14 Jan
2019
14 Jan
'19
1:04 p.m.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30827 )
Change subject: mainboard/ocp/wedge100s: Fix uart ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/30827/1/src/mainboard/ocp/wedge100s/romstage... File src/mainboard/ocp/wedge100s/romstage.c:
https://review.coreboot.org/#/c/30827/1/src/mainboard/ocp/wedge100s/romstage... PS1, Line 96: }
That should probably be configured in common code depending on devicetree.cb. […]
that sounds like a plan
--
To view, visit https://review.coreboot.org/c/coreboot/+/30827
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59cd83ed43dbf4ee26685e4a573de153291f7074
Gerrit-Change-Number: 30827
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrea Barberio insomniac@slackware.it
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 13:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Patrick Rudolph siro@das-labor.org
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment