Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )
Change subject: mb/google/zork/vilboz: Enable P sensor
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v...
PS1, Line 14: PAD_GPI
Shouldn't this be PAD_INT?
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v...
PS1, Line 140: STH9324
What kernel driver is used for this? I don't see this HID in kernel v5.4
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45565
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6294ce291365443dd1c4550ba75cb7f33481b889
Gerrit-Change-Number: 45565
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Comment-Date: Wed, 23 Sep 2020 06:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment