[coreboot-gerrit] Change in ...coreboot[master]: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30499 )

Change subject: mb/qemu-{i440fx,q35}: Use POSTCAR stage to load the ramstage
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/#/c/30499/3/src/mainboard/emulation/qemu-i440fx/... 
File src/mainboard/emulation/qemu-i440fx/romstage.c:

https://review.coreboot.org/#/c/30499/3/src/mainboard/emulation/qemu-i440fx/... 
PS3, Line 44: 	postcar_frame_add_mtrr(&pcf, 0, qemu_get_memory_size() * KiB,
> Agree. They are used in the following patches to setup correct page tables for x86_64. […]

Done

https://review.coreboot.org/#/c/30499/3/src/mainboard/emulation/qemu-q35/rom... 
File src/mainboard/emulation/qemu-q35/romstage.c:

https://review.coreboot.org/#/c/30499/3/src/mainboard/emulation/qemu-q35/rom... 
PS3, Line 42: 	postcar_frame_add_romcache(&pcf, MTRR_TYPE_WRPROT);
> As before, MTRRs are dummies on QEMU, AFAIR.

Done