Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38800 )
Change subject: soc/intel/common: Check prerequisites for GLOBAL_RESET command ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38800/12/src/soc/intel/common/block... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/38800/12/src/soc/intel/common/block... PS12, Line 611: static int cse_check_global_reset_prerequisites(void)
Return a bool? Maybe rewrite the function name as a question: […]
Renamed the function as suggested. Thanks
https://review.coreboot.org/c/coreboot/+/38800/12/src/soc/intel/common/block... PS12, Line 614: HMRFPO ENABLE
Copypasta?
Fixed it,
https://review.coreboot.org/c/coreboot/+/38800/12/src/soc/intel/common/block... PS12, Line 622: cse_is_hfs1_cws_normal()
This can be factored out: […]
Done
https://review.coreboot.org/c/coreboot/+/38800/12/src/soc/intel/common/block... PS12, Line 659: is not meeting
does not meet
Ack