Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38248 )
Change subject: soc/intel/common/cse: Add description for macros
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38248/2/src/soc/intel/common/block/...
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/38248/2/src/soc/intel/common/block/...
PS2, Line 140: Fixed
What does "Fixed" mean?
It's Fixed Address MEI Header structure. So, I named accordinly to match with ME BWG guide.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38248
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I630446234321e7998ab42f8506a58b16e9ce4eb0
Gerrit-Change-Number: 38248
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Jan 2020 06:16:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment