Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45972 )
Change subject: soc/intel/alderlake/acpi: Add SoC ACPI directory for ADL ......................................................................
Patch Set 3: Code-Review+2
(3 comments)
I would prefer if ACPI would be reused instead of copied, but without any mainboard to test ADL with, it's a bit of a mess... I would like to get an ADL board in the tree as soon as possible. I'm fine with this going in as-is now, but please ensure common ACPI is ready before adding support for another SoC. I'll be happy to review any common code changes.
https://review.coreboot.org/c/coreboot/+/45972/2/src/soc/intel/alderlake/acp... File src/soc/intel/alderlake/acpi/camera_clock_ctl.asl:
PS2:
i do expect to have some changes in this file based on ADL GPIO PIN. […]
Alright
https://review.coreboot.org/c/coreboot/+/45972/2/src/soc/intel/alderlake/acp... File src/soc/intel/alderlake/acpi/dptf.asl:
PS2:
This just gave me an idea: Why not have each SoC define its ACPI device IDs in a file? e.g. […]
Ack
https://review.coreboot.org/c/coreboot/+/45972/3/src/soc/intel/alderlake/acp... File src/soc/intel/alderlake/acpi/tcss.asl:
PS3: I expect that TCSS ACPI could be shared between TGL and ADL at some point. We can evaluate this later, though.