build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32083 )
Change subject: libpayload: Fix potential NULL pointer dereference
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/#/c/32083/12/payloads/libpayload/drivers/usb/ehc...
File payloads/libpayload/drivers/usb/ehci.c:
https://review.coreboot.org/#/c/32083/12/payloads/libpayload/drivers/usb/ehc...
PS12, Line 842: virt_to_phys(EHCI_INST(controller)->dummy_qh) | PS_TYPE_QH;
line over 80 characters
https://review.coreboot.org/#/c/32083/12/payloads/libpayload/drivers/usb/ohc...
File payloads/libpayload/drivers/usb/ohci.c:
https://review.coreboot.org/#/c/32083/12/payloads/libpayload/drivers/usb/ohc...
PS12, Line 577: fatal("Not enough DMA mem for OHCI addition TD bulk transfer.\n");
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32083
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9d4636f0429de829e746909492c2f543026a02ac
Gerrit-Change-Number: 32083
Gerrit-PatchSet: 12
Gerrit-Owner: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Francois Toguo Fotso
francois.toguo.fotso@intel.corp-partner.google.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Comment-Date: Mon, 08 Apr 2019 21:59:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment