[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Provide mmc.c for setting dll registers.

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35040 )

Change subject: soc/intel/common/block: Provide mmc.c for setting dll registers.
......................................................................

Patch Set 10:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35040/10/src/soc/intel/common/block... 
File src/soc/intel/common/block/scs/mmc.c:

https://review.coreboot.org/c/coreboot/+/35040/10/src/soc/intel/common/block... 
PS10, Line 59: if (override > 0) {
             : 		printk(BIOS_INFO, "Skip Emmc dll value programming\n");
             : 		return -1;
             : 	}
the logic doesn't seem right.
If the dll override does happen, mmc_write_dll_reg will return 1
And then, it will return -1 eventually.