Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33380 )
Change subject: Console: Allow console UART to be enabled without serial console ......................................................................
Patch Set 1:
(1 comment)
What about the loglevel approach? You could achieve the same thing with much less code churn.
https://review.coreboot.org/#/c/33380/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33380/1//COMMIT_MSG@14 PS1, Line 14: TEST=Verify UART still works, even with coreboot console disabled
Did you test that it doesn't work without this change and coreboot […]
I assume it's an issue with the use of get_uart_baudrate() in CB:25344 and CONFIG_UART_FOR_CONSOLE in CB:25345? Without CONSOLE_SERIAL those are always 0. So I guess an alternative to this would be to decouple those options from CONSOLE_SERIAL and make them always visible, but I'm not sure if that's really what we want.