Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40712 )
Change subject: drivers/intel/gma: drop gma_set_gnvs_aslb()
......................................................................
Patch Set 3:
I guess the idea was to drop the duplicated soc code at some time by using this interface, but this never happend.
I'll try to move things to CBMEM. If that works, we won't need GNVS
anymore. If it doesn't, we can still keep these functions and move
the `.write_acpi_tables` implementation into the common driver.
Please postpone this change until we know which road to take.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40712
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida23ca5ecf1821e019ed850d1eec2a858bd2e50f
Gerrit-Change-Number: 40712
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 26 Apr 2020 10:08:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment