HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46081 )
Change subject: mb/intel: Convert to ASL 2.0 syntax ......................................................................
Patch Set 5:
(8 comments)
https://review.coreboot.org/c/coreboot/+/46081/5/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/46081/5/src/mainboard/intel/tglrvp/... PS5, Line 31: One
1
Sorry, not this one
"One" is in ASL 2.0
https://review.coreboot.org/c/coreboot/+/46081/5/src/mainboard/intel/tglrvp/... PS5, Line 79: Zero
0
Sorry, "Zero" is in ASL 2.0 syntax
https://review.coreboot.org/c/coreboot/+/46081/5/src/mainboard/intel/tglrvp/... PS5, Line 117: Zero
0
Done
https://review.coreboot.org/c/coreboot/+/46081/5/src/mainboard/intel/tglrvp/... PS5, Line 129: One
1
Done
https://review.coreboot.org/c/coreboot/+/46081/5/src/mainboard/intel/tglrvp/... PS5, Line 154: Zero
0
Done
https://review.coreboot.org/c/coreboot/+/46081/5/src/mainboard/intel/tglrvp/... PS5, Line 157: (STA == Zero)
STA == 0
Ack
https://review.coreboot.org/c/coreboot/+/46081/5/src/mainboard/intel/tglrvp/... PS5, Line 372: (STA == Zero)
STA == 0
Ack
https://review.coreboot.org/c/coreboot/+/46081/5/src/mainboard/intel/tglrvp/... PS5, Line 508: One
1
Done