Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/47780 )
Change subject: Handle exit requests in all long-running functions
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/em100/+/47780/5/sdram.c
File sdram.c:
https://review.coreboot.org/c/em100/+/47780/5/sdram.c@95
PS5, Line 95: !exit_requested
Right now, after sending command 0x40 the EM100 will hang for consecutive commands (e.g. spi read id command) if not all bytes that have been announced are actually sent to the device
--
To view, visit
https://review.coreboot.org/c/em100/+/47780
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: I5fb37bba1b7398cb6db96d23b226c8b87abee9cf
Gerrit-Change-Number: 47780
Gerrit-PatchSet: 5
Gerrit-Owner: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 22 Nov 2020 06:43:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment