Attention is currently required from: Ravi kumar.
Vinod Polimera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39614 )
Change subject: sc7180: Add display dsi interface programming
......................................................................
Patch Set 40:
(2 comments)
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/39614/comment/24abb351_2b488626
PS40, Line 105: hbp = edid->mode.hbl - edid->mode.hso;
Hi Vinod, […]
video mode active h part is active + backporch+ pusle width.
Variable name has to be renamed.
https://review.coreboot.org/c/coreboot/+/39614/comment/2a419550_26e706c0
PS40, Line 122: hbp - 1));
This too is a bit confusing because you'd really just need to write […]
VIDEO_V_TOTAL-->Number of lines in one frame minus one. This value is equivalent to the period of the vertical sync.
similarly for video_h_total.
we can rewrite it to (edid->mode.ha + edid->mode.hbl -1)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39614
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie64354ce8bc2a64b891fb9478fbca38d6ec4c321
Gerrit-Change-Number: 39614
Gerrit-PatchSet: 40
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Comment-Date: Sun, 19 Sep 2021 01:53:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment